Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
Date
Msg-id 3084029.1758638342@sss.pgh.pa.us
Whole thread Raw
In response to Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master  (邱宇航 <iamqyh@gmail.com>)
Responses Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
List pgsql-hackers
=?utf-8?B?6YKx5a6H6Iiq?= <iamqyh@gmail.com> writes:
> And what about the query 2. This is caused by another commit, and
> it's not mentioned in the commit message or the mailing discussion.

That one indeed seems quite broken.  EXPLAIN confirms that it's
pushing the HAVING below the aggregation, which is simply wrong
because it fails to filter the all-null row(s) that the aggregation
node will create out of thin air.

Is there anything we can salvage from 67a54b9e, or should
we just revert it?

            regards, tom lane



pgsql-hackers by date:

Previous
From: "suyu.cmj"
Date:
Subject: Question about InvalidatePossiblyObsoleteSlot()
Next
From: Todd Lang
Date:
Subject: Supporting non-deterministic collations with tailoring rules.