Re: Extending USE_MODULE_DB to more test suite types - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Extending USE_MODULE_DB to more test suite types
Date
Msg-id 30785.1554140218@sss.pgh.pa.us
Whole thread Raw
In response to Re: Extending USE_MODULE_DB to more test suite types  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2019-04-01 06:52:13 -0700, Noah Misch wrote:
>> I plan to back-patch the PostgreSQL patch, to combat buildfarm noise.  Perhaps
>> someone has test automation that sets USE_MODULE_DB and nonetheless probes the
>> exact database name "pl_regression", but I'm not too worried.  The original
>> rationale for USE_MODULE_DB, in commit ad69bd0, was to facilitate pg_upgrade
>> testing.  Folks using "make installcheck-world" to populate a cluster for
>> pg_upgrade testing will see additional test coverage, which may cause
>> additional failures.  I'm fine with that, too.

> +1 for all of that.

I haven't tested the patch, but also +1 for the idea.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: speeding up planning with partitions
Next
From: Raymond Martin
Date:
Subject: RE: minimizing pg_stat_statements performance overhead