Re: Extending grant insert on tables to sequences - Mailing list pgsql-hackers

From Jaime Casanova
Subject Re: Extending grant insert on tables to sequences
Date
Msg-id 3073cc9b0807121232m6b8e6ae0ycaa78d6b8595d39d@mail.gmail.com
Whole thread Raw
In response to Re: Extending grant insert on tables to sequences  (Abhijit Menon-Sen <ams@oryx.com>)
Responses Re: Extending grant insert on tables to sequences  (Abhijit Menon-Sen <ams@oryx.com>)
Re: Extending grant insert on tables to sequences  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Jul 12, 2008 at 6:30 AM, Abhijit Menon-Sen <ams@oryx.com> wrote:
>
>>      <para>
>> !     Granting permission on a table automatically extend
>> !     permissions to any sequences owned by the table, including
>> !     sequences tied to <type>SERIAL</> columns.
>>      </para>
>
> Should be "Granting permissions on a table automatically extends those
> permissions to...".
>

what about "extends them to..."

>> +     if ((istmt.objtype == ACL_OBJECT_RELATION) && (istmt.all_privs ||
>> +             (istmt.privileges & (ACL_INSERT | ACL_UPDATE | ACL_SELECT))))
>> +     {
>
> The parentheses around the first comparison can go away, and also the
> ones around the ACL_* here:
>

ok

--
regards,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Guayaquil - Ecuador
Cel. (593) 87171157

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PATCH: CITEXT 2.0 v3
Next
From: Abhijit Menon-Sen
Date:
Subject: Re: Extending grant insert on tables to sequences