Re: Curious test case added by collation version tracking patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Curious test case added by collation version tracking patch
Date
Msg-id 3048706.1618267624@sss.pgh.pa.us
Whole thread Raw
In response to Re: Curious test case added by collation version tracking patch  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes:
> On Tue, Apr 13, 2021 at 8:59 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The reason I ask is that this case started failing after I fixed
>> a parse_coerce.c bug that allowed a CollateExpr node to survive
>> in this WHERE expression, which by rights it should not.  I'm
>> inclined to think that the test case is wrong and should be removed,
>> but maybe there's some reason to have a variant of it.

> Indeed, this doesn't do anything useful, other than prove that we
> record a collation dependency where it is (uselessly) allowed in an
> expression.  Since you're not going to allow that anymore, it should
> be dropped.

OK, I'll go clean it up.  Thanks!

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bryn Llewellyn
Date:
Subject: Re: Have I found an interval arithmetic bug?
Next
From: Peter Geoghegan
Date:
Subject: Teaching users how they can get the most out of HOT in Postgres 14