Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] BUG: pg_dump generates corrupted gzip file in Windows - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] BUG: pg_dump generates corrupted gzip file in Windows
Date
Msg-id 30407.1497884958@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] BUG: pg_dump generates corrupted gzip file in Windows  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
I wrote:
> That patch looks reasonable to me, will push.

On closer inspection, the patch did contain a bug: it tested for
compression being active with "compression > 0", which is the wrong
thing --- everyplace else in pg_dump tests with "compression != 0".
This is important because Z_DEFAULT_COMPRESSION is -1.  The net
effect is that the patch would have appeared to fix the bug when
writing "-Z1".."-Z9", but not when writing just "-Z".  Possibly
this explains why Kuntal couldn't confirm success at one point
upthread.

Pushed with that correction and some wordsmithing on the comment.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] BUG: pg_dump generates corrupted gzip file in Windows
Next
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] psql's \d and \dt are sending their complaints todifferent output files