BUG in XLogRecordAssemble - Mailing list pgsql-hackers

From Zhang Zq
Subject BUG in XLogRecordAssemble
Date
Msg-id 3020aba3.1f49f.14d1fab99c8.Coremail.zqzhangmail@163.com
Whole thread Raw
Responses Re: BUG in XLogRecordAssemble  (Michael Paquier <michael.paquier@gmail.com>)
Re: BUG in XLogRecordAssemble  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
hi,
   I found the code in 'backend/access/transam/xloginsert.c' as that:
XLogRecordAssemble:
 if (prev_regbuf && RelFileNodeEquals(regbuf->rnode, prev_regbuf->rnode))
        {
            samerel = true;
            bkpb.fork_flags |= BKPBLOCK_SAME_REL;
            prev_regbuf = regbuf;
        }
        else
            samerel = false;

There is the only place that prev_regbuf is assigned, so prev_regbuf will never be assigned.
The patch will fix it, Thanks.
                                                                                                                  Zhang Zq

Attachment

pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: cache invalidation for PL/pgsql functions
Next
From: Sandro Santilli
Date:
Subject: Unexpected speed PLAIN vs. MAIN