Re: [HACKERS] Duplicate node tag assignments - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Duplicate node tag assignments
Date
Msg-id 30164.1482943685@sss.pgh.pa.us
Whole thread Raw
In response to [HACKERS] Duplicate node tag assignments  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2016-12-28 11:33:31 -0500, Tom Lane wrote:
>> By chance I happened to notice that the recent partition patch pushed
>> us over the number of available node tags between
>> So I'm leaning to the second, more drastic, solution.  Thoughts?

> Alternatively we could add a -Wduplicate-enum/-Werror=duplicate-enum for
> clang. That'd protect against that in all enums...

Meh ... I'm not sure that we want to forbid it in *all* enums, just this
one.  Anyway, a lot of us are not using clang, and I could easily see
wasting a great deal of time identifying a bug caused by this sort of
conflict.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [HACKERS] Reporting planning time with EXPLAIN
Next
From: Jim Nasby
Date:
Subject: Re: [HACKERS] proposal: session server side variables