Re: seahorse again failing - Mailing list pgsql-hackers

From Tom Lane
Subject Re: seahorse again failing
Date
Msg-id 3010.1156256378@sss.pgh.pa.us
Whole thread Raw
In response to Re: seahorse again failing  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: seahorse again failing
Re: seahorse again failing
Re: seahorse again failing
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Tom Lane wrote:
>> It would be interesting to know the actual underlying Windows error code
>> --- I see that win32error.c maps several different codes to EACCES.

> It may be a good idea to put a elog(LOG) with the error code in the
> failure path of AllocateFile.

That seems like a plan to me.  I had been thinking of making
win32error.c itself log the conversions, but that would not provide any
context information.  AllocateFile could log the file name along with
the code, which should be enough info to associate a particular log
entry with the actual failure.

Note you should probably save and restore errno around the elog call,
just to be safe.

Could someone with access to Windows code and test this?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] COPY view
Next
From: "Jim C. Nasby"
Date:
Subject: Re: Autovacuum on by default?