Re: pgsql: Fix whitespace issues found by git diff --check, add gitattribut - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix whitespace issues found by git diff --check, add gitattribut
Date
Msg-id 30018.1384183578@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Fix whitespace issues found by git diff --check, add gitattribut  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-committers
Peter Eisentraut <peter_e@gmx.net> writes:
> Fix whitespace issues found by git diff --check, add gitattributes
> Set per file type attributes in .gitattributes to fine-tune whitespace
> checks.  With the associated cleanups, the tree is now clean for git

Hmm, I thought the .gitattributes file would prevent this:

$ git diff --staged --check
src/test/regress/expected/join.out:3110: trailing whitespace.
+ q1 | q2 | f1 | ff

Is there something I have to do to configure git to honor the file?

(In case it matters, this is git 1.7.1, which is what Red Hat is
shipping these days in RHEL6.)

            regards, tom lane


pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: pgsql: Don't abort pg_basebackup when receiving empty WAL block
Next
From: Tom Lane
Date:
Subject: pgsql: Re-allow duplicate aliases within aliased JOINs.