Re: Windows meson build - Mailing list pgsql-hackers

From Vladlen Popolitov
Subject Re: Windows meson build
Date
Msg-id 2fe1080dc2f42e2510b810d84eee45bd@postgrespro.ru
Whole thread Raw
In response to Re: Windows meson build  (Andres Freund <andres@anarazel.de>)
Responses Re: Windows meson build
List pgsql-hackers
Kohei Harikae (Fujitsu) писал(а) 2024-12-27 04:31:
> Hi,
> 
> Thank you for your advice.
> I added a sample setting PKG_CONFIG_PATH based on your advice.
> 
> How do you think about this?
> 
> Regards,
> Kohei Harikae
> 

Hi,
 From my point of view it looks good. Actual information is added,
excessive information is removed.
I think in the phrase:
"add the directory where the .pc file resides to PKG_CONFIG_PATH."
better to add wording, that PKG_CONFIG_PATH is the list of directories 
separated
by PATH separator ( ; in Windows, : in POSIX). Otherwise the reader has 
to
search additional information about this variable in meson 
documentation.

-- 
Best regards,

Vladlen Popolitov.



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility.
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Memory leak in pg_logical_slot_{get,peek}_changes