Re: Add header support to text format and matching feature - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Add header support to text format and matching feature
Date
Msg-id 2fa8b595-62e6-49db-02aa-a01e2455ba79@enterprisedb.com
Whole thread Raw
In response to Re: Add header support to text format and matching feature  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
On 13.06.22 04:32, Julien Rouhaud wrote:
>> I think it makes more sense to have a sanity check to prevent HEADER
>> MATCH with COPY TO.
> 
> I'm fine with it.  I added such a check and mentioned it in the documentation.

> I think it would still be problematic if the target table has dropped columns.
> Fortunately, as I initially thought the problem is only due to a thinko in the
> original commit which used a wrong variable for the raw_fields offset.  Once
> fixed (attached v1) I didn't see any other problem in the rest of the logic and
> all the added regression tests work as expected.

Thanks for this patch.  I'll check it in detail in a bit.  It looks good 
to me at first glance.



pgsql-hackers by date:

Previous
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: Replica Identity check of partition table on subscriber
Next
From: Michael Paquier
Date:
Subject: Re: Add header support to text format and matching feature