Re: pg_plan_advice - Mailing list pgsql-hackers

From Andrei Lepikhov
Subject Re: pg_plan_advice
Date
Msg-id 2e7bdb5d-68ba-4c65-9931-a865ab6fc3d2@gmail.com
Whole thread Raw
In response to Re: pg_plan_advice  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pg_plan_advice
List pgsql-hackers
On 4/4/26 20:42, Robert Haas wrote:
> On Sat, Apr 4, 2026 at 5:34 AM Andrei Lepikhov <lepihov@gmail.com> wrote:
> By the way, I'm really glad you hit that error. That particular error
> check is there precisely to find plans that pg_plan_advice isn't able
> to understand, and it sounds like it is doing its job as intended.
> Having problems isn't great, but knowing that you have problems is a
> lot better than still having them but not knowing about it.
That’s exactly what concerns me. I see it as a potential design flaw if 
the extension has to make assumptions about possible plan configurations.
I’m not sure how it works in detail, of course. However, when I designed 
Postgres replanning in the past, and made similar core changes to what 
you’ve done for pg_plan_advice, this kind of problem couldn’t have 
happened. So, I think it’s worth questioning the current approach and 
looking for other options.

-- 
regards, Andrei Lepikhov,
pgEdge



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Unused injection point in hash agg code
Next
From: Peter Eisentraut
Date:
Subject: Re: TupleDescAttr bounds checks