Re: [pgsql-patches] Ctid chain following enhancement - Mailing list pgsql-patches

From Pavan Deolasee
Subject Re: [pgsql-patches] Ctid chain following enhancement
Date
Msg-id 2e78013d0705300627w32a7afedr28fd44a3159aaef4@mail.gmail.com
Whole thread Raw
In response to Re: [pgsql-patches] Ctid chain following enhancement  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
Responses Re: [pgsql-patches] Ctid chain following enhancement  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
List pgsql-patches

On 5/29/07, Zdenek Kotala <Zdenek.Kotala@sun.com> wrote:

I'm looking on your patch. I have one comment:

If you have old tid and new tid you can easy compare if new tid points
to different page? And if page is still same there is no reason to
Unlock it and lock again. I think add inner loop something like:


Tom has already expressed his unwillingness to add complexity
without any proven benefits. Your suggestion though good would
make the code more unreadable without much benefit since the
function is not called very often.


Thanks,
Pavan

--
Pavan Deolasee
EnterpriseDB     http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: Hannes Eder
Date:
Subject: Re: [HACKERS] msvc, build and install with cygwin in the PATH
Next
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] msvc, build and install with cygwin in the PATH