Re: [PATCH] Change simple_heap_insert() to a macro - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Change simple_heap_insert() to a macro
Date
Msg-id 2e0e9725-607b-abdf-b809-3b9265b8d581@2ndquadrant.com
Whole thread Raw
In response to Re[2]: [PATCH] Change simple_heap_insert() to a macro  (Andrey Klychkov <aaklychkov@mail.ru>)
List pgsql-hackers
On 12/10/2018 12:09, Andrey Klychkov wrote:
> I don't see any reasons against to use the proposed macro instead of
> this function.

Macros are weird and should be avoided if possible.  If we were to do
this, it should be an inline function, I think.  But I think it's not
useful here.

I think there have been enough votes against this that I'll close this
CF item.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: INSTALL file
Next
From: Stephen Frost
Date:
Subject: Re: WIP Patch: Add a function that returns binary JSONB as a bytea