Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests
Date
Msg-id 2de9d128-d4da-b553-116d-b73ad5d37e98@2ndquadrant.com
Whole thread Raw
In response to Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 9/8/16 6:04 PM, Alvaro Herrera wrote:
> Andres Freund wrote:
>> On 2016-09-08 18:13:06 -0300, Alvaro Herrera wrote:
>>> I suppose -I$(srcdir) should be fine.  (Why the quotes?)
>>
>> Because quoting correctly seems like a good thing to do? Most people
>> won't have whitespace in there, but it doesn't seem impossible?
> 
> Well, I think they are used without quotes in so many places that doing
> it here seems rather pointless.

We don't support build directories with spaces in them, but we support
installation directories with spaces in them.  So I guess that means
your point is valid.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: ICU integration
Next
From: Andres Freund
Date:
Subject: Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests