Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove an unnecessary errmsg_plural in dependency.c - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Remove an unnecessary errmsg_plural in dependency.c
Date
Msg-id 2F0B7A44-F67C-4845-AF3D-668FB4248A1D@yesql.se
Whole thread Raw
In response to Re: Remove an unnecessary errmsg_plural in dependency.c  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Remove an unnecessary errmsg_plural in dependency.c  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view 
> On 24 Mar 2022, at 06:17, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:

> The comment and errmsg_plural don't seem to be consistent.  When the
> code was added by c4f2a0458d, it had only singular form and already
> had the comment.  After that 8032d76b5 turned it to errmsg_plural
> ignoring the comment.  It seems like a thinko of 8032d76b5.

Following the bouncing ball, that seems like a reasonable conclusion, and
removing the plural form should be fine to reduce translator work.

--
Daniel Gustafsson        https://vmware.com/

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [PATCH] add relation and block-level filtering to pg_waldump
Next
From: Bharath Rupireddy
Date:
Subject: Re: pg_walinspect - a new extension to get raw WAL data and WAL stats