Re: Predefined role pg_maintenance for VACUUM, ANALYZE, CHECKPOINT. - Mailing list pgsql-hackers

From Bossart, Nathan
Subject Re: Predefined role pg_maintenance for VACUUM, ANALYZE, CHECKPOINT.
Date
Msg-id 2E63F740-B422-40A8-B8B0-28CDD5FEF41F@amazon.com
Whole thread Raw
In response to Re: Predefined role pg_maintenance for VACUUM, ANALYZE, CHECKPOINT.  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: Predefined role pg_maintenance for VACUUM, ANALYZE, CHECKPOINT.
List pgsql-hackers
On 11/2/21, 10:29 AM, "Jeff Davis" <pgsql@j-davis.com> wrote:
> Great idea! Patch attached.
>
> This feels like a good pattern that we might want to use elsewhere, if
> the need arises.

The approach in the patch looks alright to me, but another one could
be to build a SelectStmt when parsing CHECKPOINT.  I think that'd
simplify the standard_ProcessUtility() changes.

Otherwise, I see a couple of warnings when compiling:
        xlogfuncs.c:54: warning: implicit declaration of function ‘RequestCheckpoint’
        xlogfuncs.c:56: warning: control reaches end of non-void function

Nathan


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Eval expression R/O once time (src/backend/executor/execExpr.c)
Next
From: Alvaro Herrera
Date:
Subject: Re: make tuplestore helper function