Re: [PATCH] Negative Transition Aggregate Functions (WIP) - Mailing list pgsql-hackers

From Florian Pflug
Subject Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Date
Msg-id 2C70B563-6562-425C-9C53-F36E39F7ACC4@phlo.org
Whole thread Raw
In response to Re: [PATCH] Negative Transition Aggregate Functions (WIP)  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: [PATCH] Negative Transition Aggregate Functions (WIP)  (Andres Freund <andres@2ndquadrant.com>)
Re: [PATCH] Negative Transition Aggregate Functions (WIP)  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
> On 04.04.2014, at 09:40, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>
> I'm not sure how much additional work is required to sort this out,
> but to me it looks more realistic to target 9.5 than 9.4, so at this
> point I tend to think that the patch ought to be marked as returned
> with feedback.

I think the patch is worthwhile, even without this additional optimization. In fact, If the optimization was part of
thepatch, there would probably be calls to factor it out, on the ground that the patch is already rather large. 

I don't see what bumping the whole thing to 9.5 buys, compared do applying what we have now, and optimizing in 9.5
further.

best regards,
Florian Pflug

PS: Sorry for the broken mail I sent earlier - miss-touched on my Phone ;-(


pgsql-hackers by date:

Previous
From: Florian Pflug
Date:
Subject: Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Next
From: yamt@netbsd.org (YAMAMOTO Takashi)
Date:
Subject: Re: Securing "make check" (CVE-2014-0067)