Re: [HACKERS] use strict in all Perl programs - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] use strict in all Perl programs
Date
Msg-id 299783de-6e9f-a105-36dd-b10c71b9e4d1@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] use strict in all Perl programs  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] use strict in all Perl programs  (David Steele <david@pgmasters.net>)
List pgsql-hackers
On 12/31/16 1:34 AM, Michael Paquier wrote:
> On Sat, Dec 31, 2016 at 3:07 PM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> Here is a patch to add 'use strict' to all Perl programs (that I could
>> find), or move it to the right place where it was already there.  I
>> think that is a pretty standard thing to do nowadays.

committed that

> What about adding as well "use warnings"? That's standard in all the TAP tests.

'use strict' can be statically checked using perl -c, but 'use warnings'
is run-time behavior, so one would have to extensively test the involved
programs.  Some cursory checking already reveals that this is going to
need to more investigation.  So in principle yes, but maybe later.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: [HACKERS] merging some features from plpgsql2 project
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity.