Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.
Date
Msg-id 29973.1281803715@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.  (rhaas@postgresql.org (Robert Haas))
Responses Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
rhaas@postgresql.org (Robert Haas) writes:
> Further dtrace adjustments for the backend-IDs-in-relpath patch.

Hrm, this doesn't look right at all.  The documentation now advertises
that backendid is passed to a number of probes that the code isn't
actually doing that for.  I agree with the changes proposed by the
docs changes, and would suggest that buffer-flush-start,
buffer-flush-done, buffer-write-dirty-start, and buffer-write-dirty-done
probes probably need to get the backendid too.  But in any case the
code isn't matching the docs in HEAD.

            regards, tom lane

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix planner to make a reasonable assumption about the amount of
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.