Re: [HACKERS] A mistake in a comment - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] A mistake in a comment
Date
Msg-id 29896.1498485244@sss.pgh.pa.us
Whole thread Raw
In response to [HACKERS] A mistake in a comment  (Victor Drobny <v.drobny@postgrespro.ru>)
List pgsql-hackers
Victor Drobny <v.drobny@postgrespro.ru> writes:
> I believe that I have found a mistake in a comment to 
> parse_phrase_operator function. The comment has the following line:
> a <X> b (distance is no greater than X)
> which is not. According to documentation and practical results, this 
> line should me changed on something like:
> a <X> b (distance is equal to X)

Ah, this comment got missed when we changed the definition of <N>.

> Patch in the attachments fixes the issue.

Will apply, thanks.  Looks to me like there's an outright bug here
as well: if errno happened to already be ERANGE when we reach the
strtol() call, the code will incorrectly report an error.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Jeevan Ladhe
Date:
Subject: Re: [HACKERS] fix empty array expression in get_qual_for_list()
Next
From: Joel Jacobson
Date:
Subject: [HACKERS] \set AUTOROLLBACK ON