John Lumby <johnlumby@hotmail.com> writes:
> On 12-01-2012 17:28, Josh Berkus wrote:
> I wonder if everyone noticed that the postgres sgml makefile is looking for the script in /bin
> (see Josh's append)
That means that configure failed to find it, and failed to determine
a setting for DOCBOOKSTYLE as well.
> I think this line in
> postgresql-9.1.3/doc/src/sgml/Makefile
> COLLATEINDEX = $(DOCBOOKSTYLE)/bin/collateindex.pl
> could be improved� -� maybe should read
> COLLATEINDEX = `which collateindex.pl`
No, that would not be an improvement. If collateindex.pl were in your
PATH, then configure would have found it (cf PGAC_PATH_COLLATEINDEX),
and so COLLATEINDEX would be set and we'd not be here at all.
Maybe the Makefile should just error out if COLLATEINDEX isn't set,
rather than trying a "fallback" value that configure has already
determined isn't going to work.
regards, tom lane
