Re: [PATCHES] Cleaning up unreferenced table files - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Cleaning up unreferenced table files
Date
Msg-id 29801.1115784154@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Cleaning up unreferenced table files  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: [PATCHES] Cleaning up unreferenced table files  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On Tue, 10 May 2005, Bruce Momjian wrote:
>> The current code is nice and localized and doesn't add any burden on our
>> existing code, which is already complicated enough.  I think we either
>> fix checkfiles.c, or we remove it and decide it isn't worth checking for
>> unrefrenced files.

> Let's pull the patch for now.

FWIW, I was OK with the idea of adding something similar to the given
patch to find out whether we had a problem or not.  With sufficient
evidence that lost files are a big problem, I'd be in favor of a
mechanism of the kind proposed in Heikki's latest messages.  The
disconnect for me at the moment is that there's no evidence to justify
that amount of effort/risk.  A startup-time patch would have provided
that evidence, or else have proven that it's not worth spending more
time on.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: --enable-thread-safety?
Next
From: Bruno Wolff III
Date:
Subject: Re: Can we get patents?