В письме от среда, 26 марта 2025 г. 21:43:42 MSK пользователь Robert Haas
написал:
> why is it worth arguing about?
I have full model of current reloptions and my patch unrolled in my head. They
have some harmony. (Mine has more harmony, but it is not the case).
isset_offset the way it is introduced breaks that harmony. Harmony worth it.
> I cannot see how this really makes any great difference.
git blame reloptions.c | grep "Robert Haas" | wc -l
112
git blame reloptions.c | grep Álvaro | wc -l
792
For me Alvary is the keeper of the concept of reloption. And he sees
difference. If he would said isset_offset is good, I will follow. Until then I
will follow my sense of harmony and code beauty as much as I can.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su