Re: Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS
Date
Msg-id 29785.1370726836@sss.pgh.pa.us
Whole thread Raw
In response to Re: Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS  (Cédric Villemain <cedric@2ndquadrant.com>)
Responses Re: Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS
List pgsql-hackers
Cédric Villemain <cedric@2ndquadrant.com> writes:
> I'm not sure of expected value of "max_safe_fds". Your patch now initialize 
> with 5 slots instead of 10, if max_safe_fds is large maybe it is better to 
> double the size each time we need instead of jumping directly to the largest 
> size ?

I don't see the point particularly.  At the default value of
max_files_per_process (1000), the patch can allocate at most 500 array
elements, which on a 64-bit machine would probably be 16 bytes each
or 8KB total.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: Batch API for After Triggers
Next
From: Noah Misch
Date:
Subject: Re: Optimising Foreign Key checks