Re: BUG #3674: Unnecessary checkpoints by WAL Writer - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #3674: Unnecessary checkpoints by WAL Writer
Date
Msg-id 29496.1192208802@sss.pgh.pa.us
Whole thread Raw
In response to BUG #3674: Unnecessary checkpoints by WAL Writer  ("ITAGAKI Takahiro" <itagaki.takahiro@gmail.com>)
Responses Re: BUG #3674: Unnecessary checkpoints by WAL Writer
List pgsql-bugs
"ITAGAKI Takahiro" <itagaki.takahiro@gmail.com> writes:
> WAL Writer requests unnecessary checkpoints with CHECKPOINT_CAUSE_XLOG.
> RedoRecPtr, declared in xlog.c, is initialized at StartupXLOG() but never
> updated in WAL Writer because it never calls XLogInsert(). It judges excess
> of segments wrongly.

Good catch.  I think the best fix for this is to make XLogWrite call
GetRedoRecPtr and recheck the condition before actually sending a
signal.

            regards, tom lane

pgsql-bugs by date:

Previous
From: "Heikki Linnakangas"
Date:
Subject: Re: libpq5 8.3 breaks 8.2 compatibility with encodings
Next
From: Martin Pitt
Date:
Subject: Re: libpq5 8.3 breaks 8.2 compatibility with encodings