Re: pgsql: Clean up some sloppy coding in repl_gram.y. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Clean up some sloppy coding in repl_gram.y.
Date
Msg-id 29475.1391437224@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Clean up some sloppy coding in repl_gram.y.  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-committers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-02-02 17:51:21 +0000, Tom Lane wrote:
>> I got interested in this because buildfarm member protosciurus has been
>> crashing in "bison repl_gram.y" since commit 858ec11.  It's a long shot
>> that this will fix that, though maybe the missing trailing semicolon
>> has something to do with it?

> Whoa? This seems to have fixed protosciurus. That's an odd cause for a
> segfault in bison...

Hah, got lucky.

I have no idea why that fixed it.  bison 1.875 on my old HPUX box
wasn't having a problem with repl_gram.y, so there must be something
not quite right about protosciurus' version.

            regards, tom lane


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Clean up some sloppy coding in repl_gram.y.
Next
From: Fujii Masao
Date:
Subject: pgsql: Make pg_basebackup skip temporary statistics files.