Re: btvacuumpage useless "orig_blkno" - Mailing list pgsql-hackers

From Tom Lane
Subject Re: btvacuumpage useless "orig_blkno"
Date
Msg-id 29399.1321928098@sss.pgh.pa.us
Whole thread Raw
In response to Re: btvacuumpage useless "orig_blkno"  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Simon Riggs's message of lun nov 21 19:11:21 -0300 2011:
>> tail recursion - read comments at bottom of the function

> Right, but we don't need to pass the value as a parameter, we can just
> save it at the start of the function, as my proposed patch does, right?

If you do this, it's not really tail recursion anymore, so the comments
need to be adjusted.  The patch sounds reasonable, but you have more
work to do to fix the comments ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: EXPLAIN (plan off, rewrite off) for benchmarking
Next
From: Tom Lane
Date:
Subject: Re: Removing postgres -f command line option