Re: Re: patch review : Add ability to constrain backend temporary file space - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: patch review : Add ability to constrain backend temporary file space
Date
Msg-id 29393.1310740219@sss.pgh.pa.us
Whole thread Raw
In response to Re: Re: patch review : Add ability to constrain backend temporary file space  (Cédric Villemain <cedric.villemain.debian@gmail.com>)
List pgsql-hackers
Cédric Villemain <cedric.villemain.debian@gmail.com> writes:
>> On 15/07/11 14:57, Tatsuo Ishii wrote:
>>> Maybe we could add more info regarding current usage and requested
>>> amount in addition to the temp file limit value. I mean something
>>> like:
>>> 
>>> ERROR: �aborting due to exceeding temp file limit. Current usage 9000kB,
>>> requested size 1024kB, thus it will exceed temp file limit 10000kB.

> Remember that what will happens is probably:

> ERROR:  aborting due to exceeding temp file limit. Current usage 8000kB,
> requested size 8008kB, thus it will exceed temp file limit 8kB.

> because temp file are increased by 8kb at once, rarely more

Yes.  I think the extra detail Tatsuo proposes is useless and possibly
confusing.  I don't object to stating the current limit, but the other
numbers are not likely to be helpful to anyone.  (If we had some way of
knowing what the file would ultimately grow to if we allowed the query
to continue, that would be useful; but of course we don't know that.)
        regards, tom lane


pgsql-hackers by date:

Previous
From: "MauMau"
Date:
Subject: Re: patch for distinguishing PG instances in event log
Next
From: Tom Lane
Date:
Subject: Re: ON COMMIT action not catalogued?