Re: GinPageIs* don't actually return a boolean - Mailing list pgsql-hackers

Andres Freund <andres@anarazel.de> writes:
> I went through all headers in src/include and checked for macros
> containing [^&]&[^&] and checked whether they have this hazard. Found a
> fair number.

> That patch also changes !! tests into != 0 style.

Looks OK to me, except I wonder why you did this#define TRIGGER_FIRED_FOR_ROW(event) \
-    ((event) & TRIGGER_EVENT_ROW)
+    (((event) & TRIGGER_EVENT_ROW) == TRIGGER_EVENT_ROW)

rather than != 0.  That way doesn't look either more efficient or
more readable.
        regards, tom lane