Re: missing toast table for pg_policy - Mailing list pgsql-hackers

From Tom Lane
Subject Re: missing toast table for pg_policy
Date
Msg-id 29346.1518970729@sss.pgh.pa.us
Whole thread Raw
In response to Re: missing toast table for pg_policy  (Joe Conway <mail@joeconway.com>)
Responses Re: missing toast table for pg_policy  (Joe Conway <mail@joeconway.com>)
Re: missing toast table for pg_policy  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Joe Conway <mail@joeconway.com> writes:
> Is there really a compelling reason to not just create toast tables for
> all system catalogs as in the attached?

What happens when you VACUUM FULL pg_class?  (The associated toast table
would have to be nonempty for the test to prove much.)

I'm fairly suspicious of toasting anything that the toast mechanism itself
depends on, actually, and that would include at least pg_attribute and
pg_index as well as pg_class.  Maybe we could get away with it because
there would never be any actual recursion only potential recursion ...
but it seems scary.

On the whole, I'm dubious that the risk/reward ratio is attractive here.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: missing toast table for pg_policy
Next
From: Tom Lane
Date:
Subject: Re: different results from plpgsql functions related to last changes in master