Re: Why does VACUUM FULL bother locking pages? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Why does VACUUM FULL bother locking pages?
Date
Msg-id 29307.1127403507@sss.pgh.pa.us
Whole thread Raw
In response to Re: Why does VACUUM FULL bother locking pages?  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Oh, certainly!  In this case, may I point out that scan_heap() does not
> bother locking pages, mentioning that "we assume that holding exclusive
> lock on the relation will keep other backends from looking at the page".
> In particular, it calls PageRepairFragmentation which runs with the page
> unlocked AFAICT.

> Seems like a bug to me.

I agree --- and a pretty silly one considering that there are LockBuffer
calls elsewhere in vacuum.c.  Wonder how old that code is ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Why does VACUUM FULL bother locking pages?
Next
From: Bruce Momjian
Date:
Subject: Re: logging blemishes