Re: speedup tidbitmap patch: cache page - Mailing list pgsql-hackers

From Tom Lane
Subject Re: speedup tidbitmap patch: cache page
Date
Msg-id 29303.1421428535@sss.pgh.pa.us
Whole thread Raw
In response to Re: speedup tidbitmap patch: cache page  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: speedup tidbitmap patch: cache page
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-12-25 01:26:53 +1300, David Rowley wrote:
>> So I think v3 is the one to go with, and I can't see any problems with it,
>> so I'm marking it as ready for committer.

> And committed.

It strikes me that this patch leaves some lookups on the table,
specifically that it fails to avoid repeated hash_search lookups
inside tbm_page_is_lossy() in the situation where we're adding
new TIDs to an already-lossified page.  Is it worth adding a few
more lines to handle that case as well?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: pg_rewind in contrib
Next
From: Pavel Stehule
Date:
Subject: Re: proposal: searching in array function - array_position