Re: pgsql: psql: add an optional execution-count limit to \watch. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: psql: add an optional execution-count limit to \watch.
Date
Msg-id 2929174.1680876023@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: psql: add an optional execution-count limit to \watch.  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: pgsql: psql: add an optional execution-count limit to \watch.
List pgsql-committers
Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Thu, Apr 6, 2023 at 8:18 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> psql: add an optional execution-count limit to \watch.

> This commit makes tests fail for me.  psql parses 'i' option of
> '\watch' using locale-aware strtod(), but 001_basic.pl uses hard-coded
> decimal separator.

Huh, yeah, I see it too if I set LANG=ru_RU.utf8 before running psql's
TAP tests.  It seems unfortunate that none of the buildfarm has noticed
this.  I guess all the TAP tests are run under C locale?

> The proposed fix is attached.

LGTM, will push in a bit (unless you want to?)

            regards, tom lane



pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: pgsql: psql: add an optional execution-count limit to \watch.
Next
From: Alexander Korotkov
Date:
Subject: Re: pgsql: psql: add an optional execution-count limit to \watch.