Re: BUG #13764: function ghstore_consistent() returns a wrong value if var "strategy" contains an unsupported number - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #13764: function ghstore_consistent() returns a wrong value if var "strategy" contains an unsupported number
Date
Msg-id 2923.1447168391@sss.pgh.pa.us
Whole thread Raw
In response to BUG #13764: function ghstore_consistent() returns a wrong value if var "strategy" contains an unsupported number  (rucsoftsec@163.com)
List pgsql-bugs
rucsoftsec@163.com writes:
> function ghstore_consistent() computes the consistency and return a bool
> value. It first computes the value of variable "strategy". It second
> executes different branches of the code depending of different value of
> variable "straregy". When the value of variable"strategy" is an unsupported
> strategy number, function  ghstore_consistent() will executes the code in
> line 584. It means function ghstore_consistent() fails, but the value of
> variable "res" is "true" which will be returned in line 586. Therefore, does
> it need to assign "false" to variable "res" after line 584?

No, because elog(ERROR) doesn't return.

            regards, tom lane

pgsql-bugs by date:

Previous
From: aslesha.akella@gmail.com
Date:
Subject: BUG #13766: weird ts_headline/ts_vector/ts_query behaviour
Next
From: Alvaro Herrera
Date:
Subject: Re: BUG #13764: function ghstore_consistent() returns a wrong value if var "strategy" contains an unsupported number