Re: Mark all GUC variable as PGDLLIMPORT - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Mark all GUC variable as PGDLLIMPORT
Date
Msg-id 2909451.1644861287@sss.pgh.pa.us
Whole thread Raw
In response to Re: Mark all GUC variable as PGDLLIMPORT  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Mark all GUC variable as PGDLLIMPORT
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> An alternative rule which would dodge that particular issue would be
> to just slap PGDLLIMPORT on every global variable in every header
> file. That would arguably be a simpler rule, though it means even more
> PGDLLIMPORT declarations floating around.

Yeah, if the objective is "level playing field for Windows",
then it's hard to avoid the conclusion that we should just do that.
Again, I've never had an objection to that as the end result ---
I just wish that we could get the toolchain to do it for us.
But if we can't, we can't.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: fixing bookindex.html bloat
Next
From: Tom Lane
Date:
Subject: Re: bailing out in tap tests nearly always a bad idea