John Naylor <jcnaylor@gmail.com> writes:
> On 1/14/18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> So, for each catalog header pg_foo.h, there would be a
>> generated file, say pg_foo_d.h, containing:
>> * Natts_ and Anum_ macros for pg_foo
>> * Any EXPOSE_TO_CLIENT_CODE sections copied from pg_foo.h
>> * Any OID-value macros for entries in that catalog
> I'm on board in principle, but I have some questions:
> How do we have the makefiles gracefully handle 62 generated headers
> which need to be visible outside the backend?
There are other people around here who are better make wizards than I, but
I'm sure this is soluble. A substitution like $(CATALOG_HEADERS:_d.h=.h)
might get you started. (It looks like CATALOG_HEADERS would have to be
separated out of POSTGRES_BKI_SRCS, but that's easy.)
> If we move fmgr oid generation here as you suggested earlier, I
> imagine we don't want to create a lot of #include churn. My idea is to
> turn src/include/utils/fmgroids.h into a static file that just
> #includes catalog/pg_proc_d.h. Thoughts?
Yeah ... or vice versa. I don't know if touching the way fmgroids.h is
built is worthwhile. Certainly, if we'd built all this to begin with
we'd have unified pg_proc.h's OID macro handling with the other catalogs,
but we didn't and that might not be worth changing. I'm not strongly
convinced either way.
> And I'm curious, what is "_d" intended to convey?
I was thinking "#define" or "data". You could make as good a case for
"_g" for "generated", or probably some other choices. I don't have a
strong preference; but I didn't especially like your original suggestion
of "_sym", because that seemed like it would invite confusion with
possible actual names for catalogs. A one-letter suffix seems less
likely to conflict with anything anybody would think was a good choice
of catalog name.
> (While I'm thinking outloud, I'm beginning to think that these headers
> lie outside the scope of genbki.pl, and belong in a separate script.)
Maybe, but the conditions for regenerating these files would be exactly
the same as for the .bki file, no? So we might as well just have one
script do both, rather than writing duplicative rules in the Makefiles
and the MSVC scripts.
regards, tom lane
