Re: fairywren hung in pg_basebackup tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: fairywren hung in pg_basebackup tests
Date
Msg-id 2890057.1658933924@sss.pgh.pa.us
Whole thread Raw
In response to Re: fairywren hung in pg_basebackup tests  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: fairywren hung in pg_basebackup tests
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> The alternative I thought of would be to switch msys to using our
> dirent.c. Probably not too hard, but certainly more work than reverting.

If you ask me, the shortest-path general-purpose fix is to insert

#if MSYS
    if (pgwin32_is_junction(path))
        return PGFILETYPE_DIR;
#endif

at the start of get_dirent_type.  (I'm not sure how to spell the
#if test.)  We could look at using dirent.c later, but I think
right now it's important to un-break the buildfarm ASAP.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robins Tharakan
Date:
Subject: autoprewarm worker failing to load
Next
From: Tom Lane
Date:
Subject: Re: autoprewarm worker failing to load