Re: Errands around AllocateDir() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Errands around AllocateDir()
Date
Msg-id 28855.1512414013@sss.pgh.pa.us
Whole thread Raw
In response to Re: Errands around AllocateDir()  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Errands around AllocateDir()
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Dec 4, 2017 at 12:05 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The only part of this that seems likely to be controversial is the
>> decision to get rid of special-case error messages, eg replace
>> "could not open tablespace directory \"%s\": %m"
>> with the more generic
>> "could not open directory \"%s\": %m"
>> As I said in the previous thread, I don't see anything much wrong
>> with that; but if anyone doesn't like it, speak now.

> I find that change an improvement, but not something to back-patch.

Yeah, agreed.  The only thing I'm concerned about back-patching is
the places where a wrong errno might be reported.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Silly API for do_pg_start_backup()
Next
From: Alvaro Herrera
Date:
Subject: Re: Errands around AllocateDir()