Re: Use INT_MAX for wal size related gucs's max value - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Use INT_MAX for wal size related gucs's max value
Date
Msg-id 2881720.1681875236@sss.pgh.pa.us
Whole thread Raw
In response to Use INT_MAX for wal size related gucs's max value  (Junwang Zhao <zhjwpku@gmail.com>)
Responses Re: Use INT_MAX for wal size related gucs's max value
List pgsql-hackers
Junwang Zhao <zhjwpku@gmail.com> writes:
> The wal size related gucs use the MB unit, so we should just use
> INT_MAX instead of MAX_KILOBYTES as the max value.

The point of MAX_KILOBYTES is to avoid overflow when the value
is multiplied by 1kB.  It does seem like that might not be
appropriate for these values, but that doesn't mean that we can
blithely go to INT_MAX.  Have you chased down how they are used?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Junwang Zhao
Date:
Subject: Use INT_MAX for wal size related gucs's max value
Next
From: Junwang Zhao
Date:
Subject: Re: Use INT_MAX for wal size related gucs's max value