Re: [RFC] obtaining the function call stack - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [RFC] obtaining the function call stack
Date
Msg-id 28619.1247513622@sss.pgh.pa.us
Whole thread Raw
In response to Re: [RFC] obtaining the function call stack  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: [RFC] obtaining the function call stack
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Tom Lane wrote:
>> The performance and error recovery implications are unfavorable.
>> Just how badly do you need this, and for what?

> Mainly for debugging.  The situation is such that there is a lot of
> functions and very high load.  The functions have embedded "debug elogs"
> and the intention is to call them only if the function was called in a
> particular context.

I can't really see that as sufficiently widely useful to justify
inserting such a mechanism.

I suspect also that you are defining the problem the wrong way --- this
user doesn't want a generic fmgr call stack, he wants a plpgsql stack.
Which is something the plpgsql debugger could be taught to do, if it
doesn't already, thus avoiding the overhead the 99.9% of the time that
you don't need it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Alpha release process
Next
From: Pavel Stehule
Date:
Subject: Re: [RFC] obtaining the function call stack