Re: Synchronize with imath upstream - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Synchronize with imath upstream
Date
Msg-id 28536.1549601778@sss.pgh.pa.us
Whole thread Raw
In response to Re: Synchronize with imath upstream  (Noah Misch <noah@leadboat.com>)
Responses Re: Synchronize with imath upstream  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
> On Thu, Feb 07, 2019 at 10:12:05AM -0500, Tom Lane wrote:
>> I have no particular opinion on whether pgindent should be part of the
>> mix for imath, but I do strongly recommend setting up and documenting a
>> reproducible import process, as I did for src/timezone.

> Good idea.  I've modified the imath.c header comment to take the form of an
> import process; see attached imath1.29-pgedits-v2.patch.

Maybe easier to keep the instructions in a separate README file?
(I don't see a need to put a PG copyright in this file, when the
mods from upstream are this small.)

Looks good otherwise.

            regards, tom lane


pgsql-hackers by date:

Previous
From: "Imai, Yoshikazu"
Date:
Subject: RE: speeding up planning with partitions
Next
From: Andres Freund
Date:
Subject: Re: Allow some recovery parameters to be changed with reload