Re: conditional dropping of columns/constraints - Mailing list pgsql-hackers

From Tom Lane
Subject Re: conditional dropping of columns/constraints
Date
Msg-id 28529.1241646180@sss.pgh.pa.us
Whole thread Raw
In response to Re: conditional dropping of columns/constraints  (Andres Freund <andres@anarazel.de>)
Responses Re: conditional dropping of columns/constraints  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> As this is my first patch to PG I am happy with most sort of feedback.

Please add your patch to the commit-fest queue here:
http://wiki.postgresql.org/wiki/CommitFestInProgress

Since we are still busy with 8.4 beta, it's unlikely that anyone will
take a close look until the next commit fest begins.  FWIW, I took a
very fast look through the patch and thought it was at least touching
the right places, except I think you missed equalfuncs.c.  (It'd be a
good idea to grep for all uses of AlterTableCmd struct to see if you
missed anything else.)  I don't have time now to look closer or do any
testing.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Patch to fix search_path defencies with pg_bench
Next
From: Tom Lane
Date:
Subject: Re: bytea vs. pg_dump