Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] pgbench tap tests fail if the path contains a perl special character - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Date
Msg-id 28495.1547832949@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] pgbench tap tests fail if the path contains a perl special character  (Raúl Marín Rodríguez <rmrodriguez@carto.com>)
Responses Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character  (Raúl Marín Rodríguez <rmrodriguez@carto.com>)
List pgsql-hackers
Tree view 
=?UTF-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= <rmrodriguez@carto.com> writes:
> As mentioned in the subject, if the $PATH where you are building postgres
> contains a perl's special character [1], for example a `+`, pgbench's tap
> tests will fail.

Fun.  But is that really the only place that fails?

> I'm attaching a patch to fix this by using quotemeta [3].

This does not look right to me: glob has a different set of special
characters than regexes, no?

            regards, tom lane

pgsql-hackers by date:

Previous
From: Raúl Marín Rodríguez
Date:
Subject: [PATCH] pgbench tap tests fail if the path contains a perl special character
Next
From: Raúl Marín Rodríguez
Date:
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character