Re: join pushdown and issue with foreign update - Mailing list pgsql-hackers

From Tom Lane
Subject Re: join pushdown and issue with foreign update
Date
Msg-id 2845636.1622571541@sss.pgh.pa.us
Whole thread Raw
In response to Re: join pushdown and issue with foreign update  (Alexander Pyhalov <a.pyhalov@postgrespro.ru>)
Responses Re: join pushdown and issue with foreign update  (Alexander Pyhalov <a.pyhalov@postgrespro.ru>)
Re: join pushdown and issue with foreign update  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Alexander Pyhalov <a.pyhalov@postgrespro.ru> writes:
> What about the following patch?

ISTM that using a specific rowtype rather than RECORD would be
quite disastrous from the standpoint of bloating the number of
distinct resjunk columns we need for a partition tree with a
lot of children.  Maybe we'll have to go that way, but it seems
like an absolute last resort.

I think a preferable fix involves making sure that the correct
record-type typmod is propagated to record_in in this context.
Alternatively, maybe we could insert the foreign table's rowtype
during execution of the input operation, without touching the
plan as such.

Could we start by creating a test case that doesn't involve
uncommittable hacks to the source code?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: CALL versus procedures with output-only arguments
Next
From: Alexander Pyhalov
Date:
Subject: Re: join pushdown and issue with foreign update