Re: Make copyObject work in C++ - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Make copyObject work in C++
Date
Msg-id 2844370.1765136707@sss.pgh.pa.us
Whole thread Raw
In response to Make copyObject work in C++  (Jelte Fennema-Nio <postgres@jeltef.nl>)
Responses Re: Make copyObject work in C++
Re: Make copyObject work in C++
List pgsql-hackers
Jelte Fennema-Nio <postgres@jeltef.nl> writes:
> Calling copyObject fails in C++ with an error like in most setups:
> error: use of undeclared identifier 'typeof'; did you mean 'typeid'
> This is due to the C compiler supporting used to compile postgres
> supporting typeof, but that function actually not being present in the
> C++ compiler. This fixes that by using decltype instead of typeof when
> including the header in C++.

Hmm, this only fixes the one use-case.  Admittedly we have only one
use-case, but as soon as we have another we'll have a new problem.
How about instead modifying the macro?  Maybe something like this
in c.h (untested):

#ifdef __cplusplus
#undef typeof
#define typeof decltype
#define HAVE_TYPEOF 1
#endif

> Another approach would be to force the value of HAVE_TYPEOF to 0 if __cplusplus.

That would be sad, because we'd lose the type checking ability
of copyObject() in C++ code.

BTW, grepping finds a number of random references to __typeof__ and
__typeof, which probably ought to be updated to be just typeof.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Marcos Magueta
Date:
Subject: Re: WIP - xmlvalidate implementation from TODO list
Next
From: David Rowley
Date:
Subject: Re: Support tid range scan in parallel?