Re: APC/socket fix (final?) - Mailing list pgsql-patches

From Tom Lane
Subject Re: APC/socket fix (final?)
Date
Msg-id 28408.1080343166@sss.pgh.pa.us
Whole thread Raw
In response to APC/socket fix (final?)  (Claudio Natoli <claudio.natoli@memetrics.com>)
List pgsql-patches
"Magnus Hagander" <mha@sollentuna.net> writes:
>>> No need to touch the frontend parts at all. Our APCs are server side
>>> only, so it's not a problem there.
>>
>> Oh really?  What if the surrounding app uses APCs?

> Then I'd say it's that apps problem. And it's clearly nothing new - the
> problem has existed before.

Not if the app itself doesn't use the broken select() code.  In that
scenario, it's *our* problem and not the app's.

> I don't think it's a good idea in general to redefine something as
> fundamental as select, send, recv etc from libpq-fe.h (or files included
> from there).

Certainly not; the redefinition would have to be in files that are not
part of the exported API.  However this is not difficult.  port.h is not
included by libpq-fe.h.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: APC/socket fix (final?)
Next
From: "Magnus Hagander"
Date:
Subject: Re: APC/socket fix (final?)