Re: fix_PGSTAT_NUM_TABENTRIES_macro patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: fix_PGSTAT_NUM_TABENTRIES_macro patch
Date
Msg-id 28374.1388514339@sss.pgh.pa.us
Whole thread Raw
In response to Re: fix_PGSTAT_NUM_TABENTRIES_macro patch  (Mark Dilger <markdilger@yahoo.com>)
Responses Re: fix_PGSTAT_NUM_TABENTRIES_macro patch
List pgsql-hackers
Mark Dilger <markdilger@yahoo.com> writes:
> I don't care for the places in the code that say things like

> ��� foo - sizeof(int)

> where "int" refers implicitly to a specific variable or struct field, but
> you have to remember that and change it by hand if you change the
> type of the variable or struct.

> But this sort of code is quite common in postgres, and not
> at all unique to src/include/pgstat.h.

Really?  I think we're using offsetof for this type of thing in most
places.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: fix_PGSTAT_NUM_TABENTRIES_macro patch
Next
From: Pavel Stehule
Date:
Subject: proposal: persistent plpgsql plugin info - field plugin_info for plpgsql_function structure