Re: updated patch for foreach stmt - Mailing list pgsql-hackers

From Tom Lane
Subject Re: updated patch for foreach stmt
Date
Msg-id 28328.1297820691@sss.pgh.pa.us
Whole thread Raw
In response to Re: updated patch for foreach stmt  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: updated patch for foreach stmt  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Feb 8, 2011 at 3:26 PM, Stephen Frost <sfrost@snowman.net> wrote:
>> Alright, so, like I said, I really like this feature and would like to
>> see it included.

> Amen to that!

> I think the syntax Tom suggested before was FOREACH thingy IN ARRAY
> arr rather than just FOREACH thingy IN arr.

Actually, I'm on record as saying the opposite: we shouldn't need to
distinguish the exact data type at the syntax level, so long as the
FOREACH construct is understood to mean "iterate through the members of
the composite object produced by this expression":

http://archives.postgresql.org/pgsql-hackers/2010-12/msg01579.php

I am not, however, wedded to that position --- if people are happier
with explicit use of ARRAY here, I won't fight hard to get rid of it.

Anyway I'm going to start on this patch next, so last chance for
opinions about the syntax ...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Usability tweaks for extension commands
Next
From: Mark Kirkwood
Date:
Subject: 9.1 (git head) does not compile using --with-libedit-preferred on Ubuntu 10.10