Re: [Bug Fix] ECPG: could not use set xxx to default statement - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [Bug Fix] ECPG: could not use set xxx to default statement
Date
Msg-id 28294.1550550435@sss.pgh.pa.us
Whole thread Raw
In response to [Bug Fix] ECPG: could not use set xxx to default statement  ("Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>)
Responses Re: [Bug Fix] ECPG: could not use set xxx to default statement  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
"Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com> writes:
> [ missing semicolon in gram.y breaks ecpg parsing of same construct ]

That's pretty nasty.  The fix in gram.y is certainly needed, but I'm
unexcited by the regression test additions you propose.  What I really
want to know is why a syntax error in gram.y wasn't detected by any
of the tools we use, and whether we can do something about that.
Otherwise the next bug of the same kind may go just as undetected;
in fact, I've got little confidence there aren't other such omissions
already :-(

            regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Prepared transaction releasing locks before deregistering its GID
Next
From: Michael Paquier
Date:
Subject: Re: Prevent extension creation in temporary schemas